Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impc: Support smoothing in rollout and forward dynamics #73

Open
hjsuh94 opened this issue Mar 3, 2023 · 1 comment
Open

impc: Support smoothing in rollout and forward dynamics #73

hjsuh94 opened this issue Mar 3, 2023 · 1 comment
Assignees

Comments

@hjsuh94
Copy link
Collaborator

hjsuh94 commented Mar 3, 2023

Currently, the way that irs_mpc_params.rollout_forward_dynamics_mode is implemented is a big bugged.

When we pass ForwardDynamics.SocpMp, ForwardDynamics.QpMp to irs_mpc, it would do fine. However, if we pass one of the smoothing modes such as ForwardDynamicsMode.kLogIcecream, it complains that kappa is set to nan because we never initialize it. (Probably same for randomized smoothing)

I think the reason is that we set a separate parameter for rollout (sim_p_rollout) since the original impc does rollout over true dynamics. But when we input the smoothing modes we never update the parameters of sim_p_rollout.

Will be submitting a fix soon.

@hjsuh94 hjsuh94 self-assigned this Mar 3, 2023
@pangtao22
Copy link
Owner

If we continue to develop this repo, we need some unit tests to keep the notebook examples running correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants