Optional support for synchronous HTTP filesystem #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moradology
force-pushed
the
feature/optional-sync-http
branch
from
c682cae
to
b8a03c0
Compare
|
@moradology I just tried this locally with the pyspark runner and it worked great! Thanks for opening this PR. One minor nit. Would it be possible to add some ImportError if |
moradology
force-pushed
the
feature/optional-sync-http
branch
from
0b323b1
to
7ab0e71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a flag that enables the experimental support for a synchronous alternative to the HTTP/S filesystems provided by FSSpec. Fairly extensive profiling with xarray reveals that this is quite likely slower than the default case but enabling it allows us to reduce the async/concurrency surface area of the code which may avoid or at least help debug potential deadlocking issues.