Move logic from schema accumulator object to combinefn #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moradology
force-pushed
the
feature/simplify-schema-combine
branch
from
0bc8b2b
to
438b6f3
Compare
ranchodeluxe
reviewed
Apr 3, 2024
| @@ -108,85 +106,3 @@ def test_schema_to_template_ds_attrs(): | |||
|
|
|||
| assert dst.attrs["pangeo-forge:test_attr_key"] == "test_attr_value" | |||
| assert dst.attrs["original_attrs_key"] == "original_attrs_value" | |||
|
|
|||
|
|
|||
| def test_concat_accumulator(): | |||
There was a problem hiding this comment.
Your changes above make sense but I see you are removing tests here. Should we be keeping some of these?
There was a problem hiding this comment.
Yeah, that's doable directly via the combinefn. Should be fairly easy...
moradology
force-pushed
the
feature/simplify-schema-combine
branch
from
33c4874
to
b60f896
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema accumulator object is basically a tuple. Its methods duplicate the intent of CombineFn's methods and this doesn't seem necessary.
These changes surface the reduce behavior of a combineFn in terms of pure functions. The tests will reflect this as now results from prior combination operations have to be threaded through manually (beam handles this in the normal context)