Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphical issues dask-labextension #467

Closed
jbusecke opened this issue Jun 28, 2023 · 6 comments
Closed

Graphical issues dask-labextension #467

jbusecke opened this issue Jun 28, 2023 · 6 comments

Comments

@jbusecke
Copy link
Collaborator

Describe the bug
The usual tabs of the dask-labextension look wonky and show no logos. Super minor issue (that should be adressed upstream I guess), but still wanted to mention it.

To Reproduce
Steps to reproduce the behavior:

  1. Open any window from the dask-labextension sidebar

Expected behavior
I expected the logos/tab riders to look cleaner.

Docker Image Version (e.g. quay.io/pangeo/ml-notebook:2023.02.27):

Infrastructure (Where you are running this image):

  • LEAP-Pangeo JupyterHub (leap.2i2c.cloud)

Screenshots
The sidebar icon:
image

The actual windows
image

Additional context
Contrary to e.g. #466 this problem is persistent on both safari and chrome

@jbusecke
Copy link
Collaborator Author

I just tried this with pangeo/pangeo-notebook:2023.05.18, and did not see these issues. I suspect this is a problem with jupyterlab 4.0.2?

@weiji14
Copy link
Member

weiji14 commented Jun 30, 2023

I just tried this with pangeo/pangeo-notebook:2023.05.18, and did not see these issues. I suspect this is a problem with jupyterlab 4.0.2?

Thanks for the detailed bug report @jbusecke! Looking at the differences from 2023.05.18...2023.06.20, it looks like we upgraded jupyterlab from 3.6.3 to 4.0.2, so that might be it. Tag 2023.06.07 uses jupyterlab 4.0.1 also, so that probably won't work either.

It looks like JupyterLab 4 compatibility is being worked on at dask/dask-labextension#263, we'll make sure to update things as soon as they release a new version with that patch.

@mahendrapaipuri
Copy link

This has been fixed in dask-labextension#262. But I think there was no release with this PR after. If you install dask-labextension from main, it should work.

@jbusecke
Copy link
Collaborator Author

jbusecke commented Jul 6, 2023

Thanks @mahendrapaipuri Ill wait for the next pangeo-docker-image release which will hopefully include this. Feel free to close this or keep open until new release

@weiji14
Copy link
Member

weiji14 commented Sep 20, 2023

We've updated dask-labextension to 7.0.0 (released 5 Aug 2023) in #481, and tagged 2023.09.11 and 2023.09.19 since. Can you check if the issue has been resolved @jbusecke? Might need to point the LEAP JupyterHub to one of these newer docker images first.

@jbusecke
Copy link
Collaborator Author

Just tested and looks good. Thanks so much! I will close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants