Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trusted publishing workflows for TestPyPI and PyPI deployments #840

Merged
merged 6 commits into from
Nov 8, 2023

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Nov 8, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Follows up on comments in #839

To-Do List

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Verified working in other projects/repositories

Checklist (while developing)

  • CHANGELOG is updated with reference to this PR.

@Zeitsperre Zeitsperre added the CI label Nov 8, 2023
@Zeitsperre Zeitsperre self-assigned this Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #840 (9afa5ce) into main (dafd1f3) will decrease coverage by 2.08%.
Report is 77 commits behind head on main.
The diff coverage is 90.68%.

@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
- Coverage   93.80%   91.73%   -2.08%     
==========================================
  Files          59       59              
  Lines        6235     6246      +11     
==========================================
- Hits         5849     5730     -119     
- Misses        386      516     +130     
Files Coverage Δ
climpred/__init__.py 100.00% <100.00%> (ø)
climpred/conftest.py 96.18% <100.00%> (-1.80%) ⬇️
climpred/graphics.py 83.81% <100.00%> (-12.17%) ⬇️
climpred/horizon.py 96.55% <ø> (ø)
climpred/logging.py 90.90% <100.00%> (-9.10%) ⬇️
climpred/metrics.py 91.82% <100.00%> (+0.09%) ⬆️
climpred/options.py 81.48% <ø> (ø)
climpred/prediction.py 91.75% <100.00%> (-1.30%) ⬇️
climpred/reference.py 96.90% <100.00%> (-1.53%) ⬇️
climpred/stats.py 84.88% <100.00%> (+1.35%) ⬆️
... and 32 more

... and 1 file with indirect coverage changes

Copy link
Collaborator

@aaronspring aaronspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don’t understand how this doesn’t need secrets but very ok with that

@Zeitsperre
Copy link
Collaborator Author

This is looking good. Will merge when the actions clear and open a new PR to prepare the release.

@Zeitsperre Zeitsperre merged commit e4d4146 into main Nov 8, 2023
25 checks passed
@Zeitsperre Zeitsperre deleted the add-trusted-publishing branch January 3, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants