Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require pooch #830

Merged
merged 1 commit into from
Oct 3, 2023
Merged

require pooch #830

merged 1 commit into from
Oct 3, 2023

Conversation

mathause
Copy link
Contributor

@mathause mathause commented Oct 2, 2023

Description

The doctests fail because pooch is missing. It was probably removed as a required dependency in one of your dependencies. I add it to requirements.txt because you have cf-xarray as core dependency (could be debated). Let's see if this gets the tests to run...

(xref conda-forge/climpred-feedstock#26 - more PRs may come)

Closes #(issue)

To-Do List

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Performance (if you modified existing code run asv to detect performance changes)
  • Refactoring
  • Improved Documentation

How Has This Been Tested?

  • Tests added for pytest, if necessary.

Checklist (while developing)

  • I have added docstrings to all new functions.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the sphinx documentation, if necessary.
  • Any new functions are added to the API. (See contribution guide)
  • CHANGELOG is updated with reference to this PR.

References

@aaronspring
Copy link
Collaborator

ignore binder link commenter, now deleted

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #830 (d491740) into main (dafd1f3) will decrease coverage by 1.03%.
Report is 71 commits behind head on main.
The diff coverage is 90.35%.

@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
- Coverage   93.80%   92.78%   -1.03%     
==========================================
  Files          59       59              
  Lines        6235     6247      +12     
==========================================
- Hits         5849     5796      -53     
- Misses        386      451      +65     
Files Coverage Δ
climpred/conftest.py 96.18% <100.00%> (-1.80%) ⬇️
climpred/horizon.py 96.55% <ø> (ø)
climpred/logging.py 90.90% <100.00%> (-9.10%) ⬇️
climpred/metrics.py 91.82% <100.00%> (+0.09%) ⬆️
climpred/options.py 81.48% <ø> (ø)
climpred/prediction.py 91.75% <100.00%> (-1.30%) ⬇️
climpred/reference.py 96.92% <100.00%> (-1.51%) ⬇️
climpred/stats.py 84.88% <100.00%> (+1.35%) ⬆️
climpred/tests/test_PerfectModelEnsemble_class.py 99.01% <100.00%> (+0.05%) ⬆️
climpred/tests/test_alignment.py 100.00% <100.00%> (ø)
... and 28 more

... and 1 file with indirect coverage changes

@aaronspring aaronspring merged commit 64afbd3 into pangeo-data:main Oct 3, 2023
19 of 20 checks passed
@mathause mathause deleted the require_pooch branch October 3, 2023 11:12
@mathause mathause mentioned this pull request Oct 3, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants