Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add herbie notebook #811

Merged
merged 8 commits into from
Feb 14, 2023
Merged

add herbie notebook #811

merged 8 commits into from
Feb 14, 2023

Conversation

aaronspring
Copy link
Collaborator

@aaronspring aaronspring commented Jan 15, 2023

Description

Closes #810

To-Do List

Type of change

  • Improved Documentation

Checklist (while developing)

  • I have updated the sphinx documentation, if necessary.
  • CHANGELOG is updated with reference to this PR.

References

https://herbie.readthedocs.io/en/latest/user_guide/_tutorial_notebooks/fast.html

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions
Copy link

Checkout your PR on Binder. Open the console and pip install -e . before using the notebooks to use climpred from this PR.

@aaronspring
Copy link
Collaborator Author

aaronspring commented Jan 15, 2023

Would be great to have a query to download multi-lead, multi-member, multi-init with Herbie - is that possible @blaylockbk?

I decided for multi-member to use the PerfectModel approach comparing one member to another, but HindcastEnsemble is more useful to most users. EDIT: taking lead 0 as pseudo obs

@aaronspring
Copy link
Collaborator Author

Would be great to have a query to download multi-lead, multi-member, multi-init with Herbie - is that possible @blaylockbk?

I decided for multi-member to use the PerfectModel approach comparing one member to another, but HindcastEnsemble is more useful to most users.

for multi leads see blaylockbk/Herbie#121 which loops over multi-inits

@aaronspring aaronspring marked this pull request as ready for review January 16, 2023 16:38
@blaylockbk
Copy link

Hi!
Yes, the FastHerbie class is supposed to help loop over multiple files and join them together (it's my attempt to take advantage of multithreading/multiprocessing to make it more efficient). Right now, it only loops over multiple init times and forecast lead times. It would be a good idea to extend it to multiple members.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #811 (469b78c) into main (dafd1f3) will decrease coverage by 6.98%.
The diff coverage is 90.31%.

@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
- Coverage   93.80%   86.83%   -6.98%     
==========================================
  Files          59       59              
  Lines        6235     6244       +9     
==========================================
- Hits         5849     5422     -427     
- Misses        386      822     +436     
Impacted Files Coverage Δ
climpred/horizon.py 96.55% <ø> (ø)
climpred/options.py 81.48% <ø> (ø)
climpred/tests/test_graphics.py 100.00% <ø> (ø)
climpred/tests/test_hindcast_prediction.py 100.00% <ø> (ø)
climpred/tests/test_logging.py 100.00% <ø> (ø)
climpred/bootstrap.py 80.21% <72.61%> (-10.67%) ⬇️
climpred/alignment.py 91.13% <73.68%> (-5.74%) ⬇️
climpred/checks.py 94.11% <83.33%> (-1.65%) ⬇️
climpred/tests/test_HindcastEnsemble_class.py 96.51% <85.71%> (-3.49%) ⬇️
climpred/classes.py 91.94% <88.29%> (-1.56%) ⬇️
... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aaronspring aaronspring merged commit 9e8ecf0 into main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notebook downloading forecasts with herbie
2 participants