Added a caption for PlantUML diagrams #39
Conversation
|
I updated also the README to use the new captions. The |
|
Thanks @tarleb for your feedback. I will fix that as soon as possible. |
|
Clean and beautiful code, and well documented, too! There are currently no tests for the new filters, which is why the CI build fails. Can you add some? I think the figure numbering filter deserves a separate pull request, so we don't mix different things in one PR. |
|
@tarleb I removed the figure numbering filter. I will create another PR for that. Tests are added. |
|
I created an issue for Pandoc: jgm/pandoc#5436 |
|
Thanks! I'll take a look soon. |
|
The Windows issue jgm/pandoc#5436 was fixed with Pandoc 2.7.2. I updated the |
|
I finally found the time to start a review. This is a great PR and probably already in mergeable state. I'll leave some more comments inline over the next day, but those should be understood less as "needs to be changed" but more as "what do you think about". |
diagram_generator/README.md
Outdated
|
|
||
| - Any LaTeX installation. This should be configured so that | ||
| missing packages are installed automatically. This filter uses the | ||
| `pdflatex` command which is available by the system's path. Alternatively, |
There was a problem hiding this comment.
In the future (i.e., once jgm/pandoc#5221 has been resolved), we could also use pandoc's --pdf-engine option to chose a LaTeX version.
There was a problem hiding this comment.
Sounds good
|
Two other small things: the filter name currently contains a underscore, while all other filters in this repo use a hyphen to separate words; it would be good to be consistent there. I think Please let me know whether you prefer to do more work, or whether you'd rather see this merged right away. I'm okay with both options, we can still fix things after merging. |
|
Thank @tarleb for the advise :-) I fixed anything. The PR might be good to go now :-) |
|
By the way: PR #37 is might obsolete since Graphviz is included here. |
|
Great, thanks! |
Dear community,
I added a caption for PlantUML diagrams, as discussed at the mailing list, cf. https://groups.google.com/forum/#!msg/pandoc-discuss/xItcBa8OtuI/s9MoBfc_CwAJ