-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST (string dtype): resolve xfails for frame fillna and replace tests + fix bug in replace for string #60295
TST (string dtype): resolve xfails for frame fillna and replace tests + fix bug in replace for string #60295
Conversation
… + fix bug in replace for string
…frame-replace-fillna
…frame-replace-fillna
Thanks @jorisvandenbossche |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
… + fix bug in replace for string (pandas-dev#60295) (cherry picked from commit fae3e80)
Manual backport -> #60331 |
Follow-up on #60285, fixing one additional bug in the string-fallback-to-object implementation, uncovered by enabling all other replace/fillna related tests.
xref #54792