Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix inconsistent pivot table subaggregation when index is None #59629

Merged
merged 3 commits into from
Sep 7, 2024

Conversation

matiaslindgren
Copy link
Contributor

@mroeschke mroeschke requested a review from rhshadrach August 28, 2024 17:12
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

pandas/core/reshape/pivot.py Show resolved Hide resolved
@rhshadrach rhshadrach added Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Sep 3, 2024
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pandas/core/reshape/pivot.py Show resolved Hide resolved
@rhshadrach rhshadrach added this to the 3.0 milestone Sep 7, 2024
@rhshadrach rhshadrach merged commit 80b6850 into pandas-dev:main Sep 7, 2024
53 checks passed
@rhshadrach
Copy link
Member

Thanks @matiaslindgren!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: margins value incorrect with count aggfunc and no index
2 participants