Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in contributing_environment.rst #59584

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Fix typo in contributing_environment.rst #59584

merged 1 commit into from
Aug 23, 2024

Conversation

serl
Copy link
Contributor

@serl serl commented Aug 23, 2024

  • Just found a typo!
  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@serl serl requested a review from noatamir as a code owner August 23, 2024 14:05
MarcoGorelli
MarcoGorelli approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @serl

@MarcoGorelli MarcoGorelli merged commit 47af7cb into pandas-dev:main Aug 23, 2024
16 checks passed
@MarcoGorelli MarcoGorelli added this to the 3.0 milestone Aug 23, 2024
matiaslindgren pushed a commit to matiaslindgren/pandas that referenced this pull request Aug 25, 2024
@serl @matiaslindgren
Fix typo in contributing_environment.rst (pandas-dev#59584)
0bf23d2
@serl serl deleted the docs-env-variable-typo branch August 26, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

@noatamir noatamir Awaiting requested review from noatamir noatamir is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@serl @MarcoGorelli