Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Remove Index.sort #59283

Merged
merged 2 commits into from
Jul 23, 2024
Merged

CLN: Remove Index.sort #59283

merged 2 commits into from
Jul 23, 2024

Conversation

mroeschke
Copy link
Member

I think this implementation was needed back when Index subclassed numpy.ndarray. Since it's been many years since that change, I think it's just OK to remove this method since it always raises

@mroeschke mroeschke added Clean Index Related to the Index class or subclasses labels Jul 20, 2024
@mroeschke mroeschke added this to the 3.0 milestone Jul 20, 2024
rhshadrach
rhshadrach approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach merged commit 1fa5025 into pandas-dev:main Jul 23, 2024
45 checks passed
@mroeschke mroeschke deleted the rm/index/sort branch July 23, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Clean Index Related to the Index class or subclasses
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @rhshadrach