-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Add note about deprecated offset aliases #58861
Conversation
thanks @tacaswell these are only deprecated for offsets (where people always interpreted for periods (the section you've edited), is this not what you're seeing? |
The PRs pandas-dev#55792 (Y), pandas-dev#52064 (Q), and pandas-dev#55553 (M) deprecated the single letter version of the aliases in favour of the -end version of them. Add a note to the offset table about deprecations.
2a764de
to
b4d40a2
Compare
I'm getting this out of The warning I'm getting is:
which is unclear if it is an offset or period (I don't have time to run through sorting out the deprecation note generation to tell if that is easy to add or not, sorry). I've removed the changes to the table and moved the note to the other table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @tacaswell , should be right - @natmokval could you confirm please?
I agree, we should point out that we deprecated the aliases We can also mention in this note that we deprecated the aliases |
agree, thanks for taking a look cool, let's ship it then |
The PRs #55792 (Y), #52064 (Q), and #55553 (M) deprecated the single letter version of the aliases in favour of the -end version of them.
This table was missed as part of that work.
I skipped making an issue because the PR with the fix is the simplest way to express the issue!
Tests added and passed if fixing a bug or adding a new featureAll code checks passed.Added type annotations to new arguments/methods/functions.Added an entry in the latestdoc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.