Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: Clean up concat statefullness and validation #57933

Merged
merged 4 commits into from
Mar 20, 2024
Merged

REF: Clean up concat statefullness and validation #57933

merged 4 commits into from
Mar 20, 2024

Conversation

mroeschke
Copy link
Member

  • Removed an additional pass over objs during validation
  • Removed methods off of _Concatenator that did not rely on self

@mroeschke mroeschke added Refactor Internal refactoring of code Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Mar 20, 2024
@mroeschke mroeschke added this to the 3.0 milestone Mar 20, 2024
@mroeschke mroeschke merged commit 825dfe4 into pandas-dev:main Mar 20, 2024
46 checks passed
@mroeschke mroeschke deleted the ref/concat/validate branch March 20, 2024 21:00
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@mroeschke @pmhatre1
REF: Clean up concat statefullness and validation (pandas-dev#57933)
b62259c 
* REF: Clean up concat statefullness and validation

* Use DataFrame again

* Ignore false positive mypy?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Refactor Internal refactoring of code Reshaping Concat, Merge/Join, Stack/Unstack, Explode
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @WillAyd