Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: fix SA05 errors in docstrings for pandas.core.window Expanding and Rolling, and SeriesGroupBy #57446

Merged

Conversation

williamking1221
Copy link
Contributor

@williamking1221 williamking1221 commented Feb 15, 2024

Copy link
Contributor

@jordan-d-murphy jordan-d-murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Feb 16, 2024
@mroeschke mroeschke added this to the 3.0 milestone Feb 16, 2024
@mroeschke
Copy link
Member

Thanks @williamking1221 and @jordan-d-murphy for the review

@mroeschke mroeschke merged commit 7e255a6 into pandas-dev:main Feb 16, 2024
51 checks passed
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
…nd Rolling, and SeriesGroupBy (pandas-dev#57446)

* DOC: fix SA05 errors in docstrings for pandas.core.window Expanding and Rolling, and SeriesGroupBy

* Reverted changes on removing SA05 check

* Added SA05 to list of errors for validate docstrings

---------

Co-authored-by: William Joshua King <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: fix SA05 errors in docstrings
3 participants