Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/DOC: Enforce SA01 in CI #57354

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Conversation

jordan-d-murphy
Copy link
Contributor

@jordan-d-murphy jordan-d-murphy commented Feb 11, 2024

Enforce SA01 in CI so that it can be fixed and enforced in chunks like other docstring errors.

The added functions come from the result of running scripts/validate_docstrings.py --format=actions --errors=SA01

Part of our ongoing work to continue enforcing numpydoc validations: https://numpydoc.readthedocs.io/en/latest/validation.html#built-in-validation-checks

@jordan-d-murphy
Copy link
Contributor Author

pre-commit.ci autofix

@simonjayhawkins simonjayhawkins added Docs CI Continuous Integration labels Feb 13, 2024
@jordan-d-murphy
Copy link
Contributor Author

@mroeschke I resolved the merge conflicts in code_checks.sh

can you take a look at this PR?

I opened several similar PRe for each of the outstanding numpy doc validation errors. each time we merge one it will cause conflicts with the rest, but I'll go through and update them one at a time to resolve the merge conflicts

@mroeschke mroeschke added this to the 3.0 milestone Feb 13, 2024
@mroeschke mroeschke merged commit de611a7 into pandas-dev:main Feb 13, 2024
47 checks passed
@mroeschke
Copy link
Member

Thanks @jordan-d-murphy

@jordan-d-murphy jordan-d-murphy deleted the enforce_SA01 branch February 13, 2024 20:05
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants