Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: fix EX03 errors in docstrings #56855

Merged
merged 3 commits into from
Jan 16, 2024
Merged

DOC: fix EX03 errors in docstrings #56855

merged 3 commits into from
Jan 16, 2024

Conversation

tqa236
Copy link
Contributor

@tqa236 tqa236 commented Jan 13, 2024

@tqa236 tqa236 requested a review from mroeschke as a code owner January 13, 2024 05:53
@tqa236 tqa236 force-pushed the patch-1 branch 2 times, most recently from 8c54930 to a37793d Compare January 14, 2024 07:16
@tqa236
Copy link
Contributor Author

tqa236 commented Jan 14, 2024

hi @mroeschke, I rebased and resolved the conflict but then noticed from #56863 that ruff can autofix all these errors. Let me know if I should close this MR in favor of #56863

@mroeschke
Copy link
Member

It's OK to still work on this PR. While the ruff PR may also reformat this docstring in the future, it is still appreciated to have your contribution in this PR.

@tqa236
Copy link
Contributor Author

tqa236 commented Jan 15, 2024

@mroeschke this PR is ready for review. I was about to expand it a bit but then noticed that pd.MultiIndex is already removed in this PR while the docstring is not fixed yet (The pipeline indeed raised an error here and also here on main but the pipeline is still green!).

I think we can merge this PR first to heal main?

@tqa236
Copy link
Contributor Author

tqa236 commented Jan 15, 2024

It's not the first error there too.

image

@tqa236
Copy link
Contributor Author

tqa236 commented Jan 15, 2024

I managed to reproduce the error here. Will go ahead and fix all the current bugs on main

@tqa236 tqa236 mentioned this pull request Jan 16, 2024
Closed
5 tasks
@datapythonista datapythonista merged commit e379692 into pandas-dev:main Jan 16, 2024
50 checks passed
@tqa236 tqa236 deleted the patch-1 branch January 16, 2024 08:50
@alpakpinar alpakpinar mentioned this pull request Jan 17, 2024
Closed
@tqa236 tqa236 mentioned this pull request Jan 20, 2024
Merged
5 tasks
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
@tqa236 @pmhatre1
DOC: fix EX03 errors in docstrings (pandas-dev#56855)
72594ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tqa236 @mroeschke @datapythonista