STY: Use ruff instead of black for formatting #56704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
requested review from
rhshadrach,
WillAyd and
noatamir
as code owners
twoertwein
reviewed
Jan 3, 2024
twoertwein
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
I like how ruff seems to handle the typing ignore codes slightly differently than black:
- seems like they are ignored from the line length limit (no more running mypy again after formatting moves the ignore code around); and
- ruff seems to also prefer to split arguments across lines when multiple were previously covered by a single ignore comments (this makes it easier to know which argument is causing "troubles")
twoertwein
reviewed
Jan 3, 2024
|
I've only taken a partial look, so not a full review, but from what I've seen this looks great. |
|
Thanks @mroeschke! (Merging quickly after you just rebased to avoid other PRs where ruff and black could potentially diverge.) |
4 tasks
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* STY: Use ruff instead of black for formatting * mypy * move pylint * Remove trailing comma:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.