-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Change core paths to api.typing in URLs #55626
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for addressing this
We might want to add something specifically for docs at some point
Good catch. Thanks @rhshadrach |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I missed this notification at the time, but remembering it now because it came up in the discussion about deprecating Two comments:
I am all for breaking those urls once so we can remove the "core" out of those long references (which we need to deprecating I will move the second item about what's the best location to use for the docs to the issue Patrick opened: #55632 |
This reverts commit 5c7d89d.
…" (pandas-dev#56565) This reverts commit 5c7d89d.
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.@phofl pointed out that #27522 would change the URLs in the API docs from
pandas.core
topandas._core
. We shouldn't be leaking the locations of the internals via the URLs. Whilepandas.api.typing
is perhaps a little odd, it is at least public.cc @jorisvandenbossche @jbrockmendel @mroeschke