Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: change pyarrow skips to xfails #55576

Merged
merged 6 commits into from
Oct 23, 2023
Merged

TST: change pyarrow skips to xfails #55576

merged 6 commits into from
Oct 23, 2023

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Oct 18, 2023 •
edited
Loading

phofl
phofl reviewed Oct 21, 2023
View reviewed changes
pandas/tests/io/parser/usecols/test_usecols_basic.py
skip_pyarrow = pytest.mark.usefixtures("pyarrow_skip")
xfail_pyarrow = pytest.mark.usefixtures("pyarrow_xfail")

pytestmark = pytest.mark.filterwarnings(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@jbrockmendel jbrockmendel mentioned this pull request Oct 22, 2023
Merged
phofl
phofl approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

feel free to merge when ci is finished

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Arrow pyarrow functionality labels Oct 23, 2023
@mroeschke mroeschke added this to the 2.2 milestone Oct 23, 2023
@mroeschke mroeschke merged commit f64c608 into pandas-dev:main Oct 23, 2023
33 checks passed
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the tst-skip_pyarrow branch October 23, 2023 19:48
@mroeschke mroeschke mentioned this pull request Nov 8, 2023
Closed
2 tasks
@ccccjone ccccjone mentioned this pull request Dec 8, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Arrow pyarrow functionality Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

BUG: "TODO(1.4): Change me into xfail at release time"
3 participants
@jbrockmendel @mroeschke @phofl