Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMPAT: Update old numpy aliases #55460

Merged
merged 2 commits into from
Oct 9, 2023
Merged

COMPAT: Update old numpy aliases #55460

merged 2 commits into from
Oct 9, 2023

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added the Compat pandas objects compatability with Numpy or Python functions label Oct 9, 2023
@lithomas1 lithomas1 added this to the 2.2 milestone Oct 9, 2023
@mroeschke
Copy link
Member Author

@lithomas1 do you think we should backport this to 2.1.2? It appears that Numpy 2.0 is going to remove the np.dtype("a") alias numpy/numpy#24854

@lithomas1
Copy link
Member

lithomas1 commented Oct 9, 2023 •
edited
Loading

We'd need the minimum version of Cython to be 3.0 to be fully compatible with numpy 2.0 and I'm not sure if that's going to happen before we release 2.2.
It might be better to just focus on making main(2.2) work with numpy 2.0 isntead, given we will release that in a month or two anyways.

EDIT: I changed my mind. Even if 2.1.x doesn't end up fully compatible with numpy 2.0, it'd still be good to have this in, to not have red CI there, and this is harmless enough.

@lithomas1 lithomas1 merged commit 1ab06f8 into pandas-dev:main Oct 9, 2023
33 checks passed
@lithomas1 lithomas1 modified the milestones: 2.2, 2.1.2 Oct 9, 2023
@lithomas1
Copy link
Member

thanks @mroeschke.

@lithomas1
Copy link
Member

@meeseeksdev backport 2.1.x.

1 similar comment
@lithomas1
Copy link
Member

@meeseeksdev backport 2.1.x.

@meeseeksmachine meeseeksmachine mentioned this pull request Oct 9, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Oct 9, 2023
@mroeschke @meeseeksmachine
Backport PR pandas-dev#55460: COMPAT: Update old numpy aliases
1246809
@mroeschke mroeschke deleted the compat/npalias branch October 9, 2023 22:59
mroeschke added a commit that referenced this pull request Oct 10, 2023
@meeseeksmachine @mroeschke
Backport PR #55460 on branch 2.1.x (COMPAT: Update old numpy aliases) (…
423e7b9 
…#55463)

Backport PR #55460: COMPAT: Update old numpy aliases

Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lithomas1 lithomas1 lithomas1 approved these changes

Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.

CI: npdev is failing
2 participants
@mroeschke @lithomas1