-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: Fix gitpod meson version #55331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't used Gitpod, and I fail to see why it's being more cautious adding it here than in the Dockerfile, but this seems reasonable to me, happy to get it merged.
I'll update it every so often until someone with write access comes along again. |
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Thanks for the PR, but this is currently getting overhauled in #56375 which should also solve your original issue so closing in favor of that PR |
The issue is that meson is out of date in gitpod.
pip install --upgrade meson
The above command fixes the issue, so I added it to the build instructions in gitpod.yml. It could be added to the dockerfile instead, but I decided to be cautious.
I added the update command to both the
init
andcommand
sections because gitpod sometimes skips theinit
section and goes straight to thecommand
section without installing anything.With the fix:
I'm running the tests in gitpod overnight and I'll check the log file in the morning.
Update:
These are the results:
661 failed, 211445 passed, 7990 skipped, 2426 xfailed, 15 xpassed, 405 warnings, 58 errors in 4524.22s (1:15:24)
The failed tests are the ones that interact with either S3 or a nonexistent SQL server, so I think everything works.