BLD: Build wheels for Python 3.12 #55010
Conversation
| @@ -10,7 +10,8 @@ requires = [ | |||
| # we don't want to force users to compile with 1.25 though | |||
| # (Ideally, in the future, though, oldest-supported-numpy can be dropped when our min numpy is 1.25.x) | |||
| "oldest-supported-numpy>=2022.8.16; python_version<'3.12'", | |||
| "numpy>=1.22.4; python_version>='3.12'", | |||
| # TODO: This needs to be updated when the official numpy 1.26 comes out | |||
| "numpy>=1.26.0b1; python_version>='3.12'", | |||
There was a problem hiding this comment.
I don't know if pip will pull a pre-release without explicitly specifying this.
This should be nbd though, I'm not planning on publishing the built wheels to PyPI anyways until numpy 1.26 is out.
|
Let's merge and backport this for 2.1.1. This means we'll have nightlies up for Python 3.12 and also the option to upload Python 3.12 wheels for 2.1.1 if we want. (I am still planning on waiting for numpy to release 1.26 before wheels are uploaded to PyPI. This is more so downstream can test with pandas). |
| docker pull python:${{ matrix.python[1] }}-windowsservercore | ||
| docker run --env PANDAS_CI='1' -v ${PWD}:C:\pandas python:${{ matrix.python[1] }}-windowsservercore powershell -Command $TST_CMD | ||
| # add rc to the end of the image name if the Python version is unreleased | ||
| docker pull python:${{ matrix.python[1] == '3.12' && '3.12-rc' || format('{0}-windowsservercore', matrix.python[1]) }} |
There was a problem hiding this comment.
Ideally the 3.12-rc should still be associated with windowsservercore right? Otherwise looks like this is just testing with the python:3.12-rc image
There was a problem hiding this comment.
Yes it's a shared tag iirc, so should resolve to Windows Server Core when running on Windows
There was a problem hiding this comment.
In pytest logs I see win32 as the platform, so this looks to be working
|
Thanks @lithomas1 |
#55055) Backport PR #55010: BLD: Build wheels for Python 3.12 Co-authored-by: Thomas Li <[email protected]>
* BLD: Build wheels for Python 3.12 * Update pyproject.toml * Update pyproject.toml * also circle * fix windows? * typo? * try single quotes * tyr to fix again * just use the base shared tag, no need to append windowsservercore * typo * update the other too * Update wheels.yml * try something * try something * debug * escape string? * go for green
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.