REGR: Arrow backed objects not propagating exceptions #54952
Conversation
phofl
added
Error Reporting
| @@ -626,20 +626,22 @@ def __setstate__(self, state) -> None: | |||
|
|
|||
| def _cmp_method(self, other, op): | |||
| pc_func = ARROW_CMP_FUNCS[op.__name__] | |||
| try: | |||
| if isinstance(other, (ArrowExtensionArray, np.ndarray, list, BaseMaskedArray)): | |||
There was a problem hiding this comment.
Is it possible to split the cases when ArrowNotImplementedError vs ArrowInvalid is raised? I'm a little nervous of restricting the types of other?
Additionally maybe self._box_pa should be called first before going down the array like vs scalar path
There was a problem hiding this comment.
this basically restores the logic we had before the last refactor that introduced the regression. I think calling box_pa on everything raised an exception, but can retry
There was a problem hiding this comment.
Okay if this was the logic before I'm okay having this as a patch for 2.1.1, thought I think this should be more generic in the future.
|
Hm, this is kinda annoying so I think it should go into the release. I'm not familiar enough to review this part of the code, though. @mroeschke can you take another quick look |
|
Thanks @phofl |
Co-authored-by: Matthew Roeschke <[email protected]>
…opagating exceptions) (#55209) Backport PR #54952: REGR: Arrow backed objects not propagating exceptions Co-authored-by: Patrick Hoefler <[email protected]>
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.