Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer string storage based on infer_string option #54794

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Conversation

phofl
Copy link
Member

@phofl phofl commented Aug 28, 2023

Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
I think this would be a good change to include in 2.1

@phofl
Copy link
Member Author

phofl commented Aug 28, 2023

I'll add some docs to this.

@phofl
Copy link
Member Author

phofl commented Aug 28, 2023

Updated

@jorisvandenbossche jorisvandenbossche added Strings String extension data type and string data Arrow pyarrow functionality labels Aug 28, 2023
@jorisvandenbossche jorisvandenbossche added this to the 2.1 milestone Aug 28, 2023
@phofl phofl merged commit b728d66 into pandas-dev:main Aug 29, 2023
34 of 39 checks passed
@phofl phofl deleted the string branch August 29, 2023 08:36
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 29, 2023
lithomas1 pushed a commit that referenced this pull request Aug 29, 2023
…er_string option) (#54839)

Backport PR #54794: Infer string storage based on infer_string option

Co-authored-by: Patrick Hoefler <[email protected]>
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Strings String extension data type and string data
Projects
None yet
3 participants