Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST .drop() doesn't parse strings for DatetimeIndex #52739

Merged
merged 3 commits into from
Apr 19, 2023
Merged

TST .drop() doesn't parse strings for DatetimeIndex #52739

merged 3 commits into from
Apr 19, 2023

Conversation

PrimeF
Copy link
Contributor

@PrimeF PrimeF commented Apr 18, 2023 •
edited
Loading

@PrimeF
Copy link
Contributor Author

PrimeF commented Apr 18, 2023

Linking reviewers: @phofl @noatamir @jorisvandenbossche @MarcoGorelli

@noatamir noatamir added the Sprints Sprint Pull Requests label Apr 18, 2023
MarcoGorelli
MarcoGorelli approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @PrimeF

@MarcoGorelli MarcoGorelli added this to the 2.1 milestone Apr 19, 2023
@MarcoGorelli MarcoGorelli added the Needs Tests Unit test(s) needed to prevent regressions label Apr 19, 2023
@MarcoGorelli MarcoGorelli changed the title [TST] Test drop string parsing datetimeindex for #5355 TST .drop() doesn't parse strings for DatetimeIndex Apr 19, 2023
@MarcoGorelli MarcoGorelli merged commit 6fc3da6 into pandas-dev:main Apr 19, 2023
@PrimeF PrimeF deleted the test_drop_string_parsing_datetimeindex branch April 19, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Needs Tests Unit test(s) needed to prevent regressions Sprints Sprint Pull Requests
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@PrimeF @MarcoGorelli @noatamir @fabrizioprimerano