Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Remove special cases in indexing ops #52063

Merged
merged 1 commit into from
Mar 18, 2023
Merged

CLN: Remove special cases in indexing ops #52063

merged 1 commit into from
Mar 18, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Mar 18, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl added Indexing Related to indexing on series/frames, not to indexes themselves Clean labels Mar 18, 2023
jbrockmendel
jbrockmendel approved these changes Mar 18, 2023
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@phofl phofl added this to the 2.1 milestone Mar 18, 2023
@phofl phofl merged commit 8e456d3 into pandas-dev:main Mar 18, 2023
@phofl phofl deleted the indexing_clean branch March 18, 2023 21:41
matiaslindgren added a commit to matiaslindgren/pandas that referenced this pull request Jul 27, 2024
@matiaslindgren
Revert "CLN: Remove special cases in indexing ops (pandas-dev#52063)"
27c18ce 
This reverts commit 8e456d3.
@matiaslindgren matiaslindgren mentioned this pull request Jul 27, 2024
Merged
5 tasks
matiaslindgren added a commit to matiaslindgren/pandas that referenced this pull request Jul 29, 2024
@matiaslindgren
Revert "CLN: Remove special cases in indexing ops (pandas-dev#52063)"
e2b809a 
This reverts commit 8e456d3.
mroeschke added a commit that referenced this pull request Jul 29, 2024
@matiaslindgren @mroeschke
BUG: Fix 57735 (#59335)
aa4dc71 
* Revert "CLN: Remove special cases in indexing ops (#52063)"

This reverts commit 8e456d3.

* remove old comments, add test

* use better test name

* Update pandas/tests/indexing/test_loc.py

Co-authored-by: Matthew Roeschke <[email protected]>

* check for empty index first

* assert assign to empty does not change frame

* format

---------

Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees
No one assigned
Labels
Clean Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @jbrockmendel