-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Pin matplotlib to < 3.7.0 #51393
Conversation
whats the condition under which we can revert the pin? |
#51394 links a failing build. Not really familiar with how matplotlib works, but couldn't find a whatsnew that references this |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's failures because of both MPL and openpyxl, and here you're only pinning MPL (hence some CI failures)?
Looks good to me
Yep, merging both should get ci green. |
Makes reverting easier when doing it separately |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…51429) Backport PR #51393: CI: Pin matplotlib to < 3.7.0 Co-authored-by: Patrick Hoefler <[email protected]>
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.