Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLD: Fix uploading of aarch64 wheels #51358

Merged
merged 11 commits into from
Feb 14, 2023
Merged

BLD: Fix uploading of aarch64 wheels #51358

merged 11 commits into from
Feb 14, 2023

Conversation

lithomas1
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@lithomas1 lithomas1 added the Build Library building on various platforms label Feb 13, 2023
@lithomas1 lithomas1 marked this pull request as ready for review February 13, 2023 20:24
@mroeschke
Copy link
Member

Nice, were you able to confirm a similar workflow works locally?

@lithomas1
Copy link
Member Author

lithomas1 commented Feb 14, 2023 •
edited
Loading

It should work(I tested all the way up to the actual uploading).
Unfortunately, this is the sort of thing where you have to merge and see, so this might take a couple attempts.

EDIT: NVM, found a small bug

@lithomas1 lithomas1 marked this pull request as draft February 14, 2023 00:52
lithomas1
lithomas1 commented Feb 14, 2023
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
@lithomas1 lithomas1 marked this pull request as ready for review February 14, 2023 03:07
@lithomas1 lithomas1 requested a review from mroeschke February 14, 2023 03:07
@lithomas1
Copy link
Member Author

This is ready now.

@lithomas1 lithomas1 added this to the 2.0 milestone Feb 14, 2023
@mroeschke mroeschke merged commit 74d5c19 into pandas-dev:main Feb 14, 2023
@mroeschke
Copy link
Member

Thanks @lithomas1

@lithomas1 lithomas1 deleted the fix-circle-builds branch February 14, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lithomas1 @mroeschke