Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: eval and query not working with ea dtypes #50764
BUG: eval and query not working with ea dtypes #50764
Changes from 26 commits
244a2fe
5a66970
2fee569
3142077
f01d45f
7c56d2e
c010ca9
778d043
8a3d8cb
5e2327e
cef04a3
fddee23
a23523b
5b73792
467127f
9022e2e
89fe7fd
04d9a94
5268569
2fdb1d0
9f75603
b756073
931c723
4fb7a39
a0d8120
1a2c36a
73d72ed
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean if a user is specifying
engine="numexpr"
, this switches the engine topython
?If so, I think it would be better to explicitly raise a
NotImplementedError
and tell the user to switch the engine manually.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, would you be ok with a RuntimeWarning? Since numexpr is the default, raising seems a bit noisy maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well the issues linked already raise an exception currently, so a
NotImplementedError
would be similar but more explicit. Unless there's a case I'm not thinking of.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am more concerned with people using our nullable option who are switching over from NumPy. Would be annoying if query/eval stop working then.
But you are correct, an appropriate NotImplementedError would be an improvement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair. Yeah a
RuntimeWarning
warning & encouraging users to switch to the python engine would be okayThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the warning