Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/DEPS: Fix timezone test due to pytz upgrade #48065

Merged
merged 6 commits into from
Aug 14, 2022
Merged

CI/DEPS: Fix timezone test due to pytz upgrade #48065

merged 6 commits into from
Aug 14, 2022

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Aug 12, 2022 •
edited
Loading

@mroeschke mroeschke added CI Continuous Integration Timezones Timezone data dtype labels Aug 12, 2022
@mroeschke mroeschke marked this pull request as draft August 12, 2022 19:16
@mroeschke
Copy link
Member Author

mroeschke commented Aug 12, 2022 •
edited
Loading

Looks like a change in pytz

In [1]: import pytz

In [2]: pytz.__version__
Out[2]: '2020.4'

In [3]: pytz.timezone('Africa/Kinshasa')._utc_transition_times
Out[3]: [datetime.datetime(1, 1, 1, 0, 0), datetime.datetime(1919, 8, 31, 23, 46, 24)]

In [1]: import pytz

In [2]: pytz.timezone('Africa/Kinshasa')._utc_transition_times
Out[2]:
[datetime.datetime(1, 1, 1, 0, 0),
 datetime.datetime(1905, 6, 30, 23, 46, 25),
 datetime.datetime(1908, 7, 1, 0, 0),
 datetime.datetime(1913, 12, 31, 23, 46, 25),
 datetime.datetime(1919, 8, 31, 23, 30)]

In [3]: pytz.__version__
Out[3]: '2020.5'

In [1]: import pytz

In [2]: pytz.__version__
Out[2]: '2022.1'

In [3]: pytz.timezone('Africa/Kinshasa')._utc_transition_times
Out[3]:
[datetime.datetime(1, 1, 1, 0, 0),
 datetime.datetime(1905, 6, 30, 23, 46, 25),
 datetime.datetime(1908, 7, 1, 0, 0),
 datetime.datetime(1913, 12, 31, 23, 46, 25),
 datetime.datetime(1919, 8, 31, 23, 30)]

In [1]: import pytz

In [2]: pytz.__version__
Out[2]: '2022.2'

In [3]: pytz.timezone('Africa/Kinshasa')._utc_transition_times
Out[3]: [datetime.datetime(1, 1, 1, 0, 0), datetime.datetime(1901, 12, 13, 20, 45, 52)]

@mroeschke mroeschke marked this pull request as ready for review August 12, 2022 21:11
@mroeschke mroeschke added this to the 1.4.4 milestone Aug 12, 2022
@mroeschke mroeschke changed the title CI/DEBUG: Debug 32 bit build due to pytz upgrade CI/DEBUG: Fix timezone test due to pytz upgrade Aug 12, 2022
@mroeschke mroeschke changed the title CI/DEBUG: Fix timezone test due to pytz upgrade CI/DEPS: Fix timezone test due to pytz upgrade Aug 12, 2022
@mroeschke mroeschke mentioned this pull request Aug 12, 2022
Merged
phofl
phofl approved these changes Aug 13, 2022
View reviewed changes
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tzdata update is now failing everything, should merge after this is greenish

@mroeschke mroeschke merged commit 96fe059 into pandas-dev:main Aug 14, 2022
@mroeschke mroeschke deleted the ci/32bit/pytz branch August 14, 2022 05:38
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 14, 2022
@mroeschke @meeseeksmachine
Backport PR pandas-dev#48065: CI/DEPS: Fix timezone test due to pytz …
fd6a656 
…upgrade
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 14, 2022
Merged
phofl pushed a commit that referenced this pull request Aug 14, 2022
@meeseeksmachine @mroeschke
Backport PR #48065 on branch 1.4.x (CI/DEPS: Fix timezone test due to…
8b58762 
… pytz upgrade) (#48076)

Backport PR #48065: CI/DEPS: Fix timezone test due to pytz upgrade

Co-authored-by: Matthew Roeschke <[email protected]>
@mroeschke mroeschke mentioned this pull request Aug 17, 2022
Closed
YYYasin19 pushed a commit to YYYasin19/pandas that referenced this pull request Aug 23, 2022
@mroeschke @YYYasin19
CI/DEPS: Fix timezone test due to pytz upgrade (pandas-dev#48065)
e3407e9 
* CI/DEBUG: Debug 32 bit build due to pytz upgrade

* Add interval where the data was good

* Remove debug line

* Trigger CI

* pytz bumped again; use Version

* Change condition
@vtikoo vtikoo mentioned this pull request Aug 25, 2022
Merged
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@mroeschke @noatamir
CI/DEPS: Fix timezone test due to pytz upgrade (pandas-dev#48065)
c0ec458 
* CI/DEBUG: Debug 32 bit build due to pytz upgrade

* Add interval where the data was good

* Remove debug line

* Trigger CI

* pytz bumped again; use Version

* Change condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration Timezones Timezone data dtype
Projects
None yet
Milestone
1.4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @phofl