DOC: Add to docs on group_keys in groupby.apply #47185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jun 1, 2022
pandas/core/groupby/groupby.py
Outdated
| B C | ||
| A | ||
| a 1.0 2.0 | ||
| b 0.0 0.0 | ||
|
|
||
| The ``group_keys`` argument has no effect here because the result is not | ||
| like-indexed when compared to the input. |
There was a problem hiding this comment.
I think I might be worth adding the parenthesized description of like-indexed like you did below for in the group_keys descriptions e.g. because the result is not like-indexed (transformed) compared to the input
There was a problem hiding this comment.
Thanks - I changed it to (i.e. a transform) with a link to the user guide on transforms in each place.
mroeschke
approved these changes
Jun 2, 2022
|
Thanks @rhshadrach (failure unrelated) |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
* DOC: Add to docs on group_keys in groupby.apply * Add link to user guide
6 tasks
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Sep 8, 2022
- [x] This PR adds support for `group_keys` in `groupby`. Starting pandas 1.5.0, issues around `group_keys` have been resolved: pandas-dev/pandas#34998 pandas-dev/pandas#47185 - [x] This PR defaults `group_keys` to `False` which is the same as what pandas is going to be defaulting to in the future version. - [x] Required to unblock `pandas-1.5.0` upgrade in cudf: #11617 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Bradley Dice (https://github.com/bdice) - Ashwin Srinath (https://github.com/shwina) URL: #11659
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.