TST: add test for DataFrame with duplicate indices concat #45888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataFrame.join() with duplicate indices should raise now and add test for this.
catch concat's raise, not join
|
@github-actions pre-commit |
mroeschke
added
the
Testing
mroeschke
reviewed
Feb 10, 2022
|
Merged and seems more checks are queued, let's wait and see。 |
add msg for pytest.raises for Code Check
…into df-join-test
mroeschke
reviewed
Feb 10, 2022
|
Hello @zhengfeiwang! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-02-11 11:41:58 UTC |
remove whitespace in blank line
add detailed description for test, also tend to trigger all checks
…into df-join-test
use concat directly instead of pd.concat for flake8
mroeschke
approved these changes
Feb 11, 2022
|
Thanks @zhengfeiwang |
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Feb 14, 2022
…#45888) * add test for DataFrame.join() DataFrame.join() with duplicate indices should raise now and add test for this. * Update test_join.py catch concat's raise, not join * Fixes from pre-commit [automated commit] * Update test_join.py add msg for pytest.raises for Code Check * move new test to concat * Update test_concat.py remove whitespace in blank line * Fixes from pre-commit [automated commit] * Update test_concat.py add detailed description for test, also tend to trigger all checks * Update test_concat.py use concat directly instead of pd.concat for flake8
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
…#45888) * add test for DataFrame.join() DataFrame.join() with duplicate indices should raise now and add test for this. * Update test_join.py catch concat's raise, not join * Fixes from pre-commit [automated commit] * Update test_join.py add msg for pytest.raises for Code Check * move new test to concat * Update test_concat.py remove whitespace in blank line * Fixes from pre-commit [automated commit] * Update test_concat.py add detailed description for test, also tend to trigger all checks * Update test_concat.py use concat directly instead of pd.concat for flake8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Previously DataFrame with duplicate indices will raise ValueError. With some changes, this will raise InvalidIndexError. This PR add a test for this behavior.