Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: [Draft] Fix issue #35131 Identify zero-dimensional duck arrays as non-iterable #44626

Merged
merged 20 commits into from
Dec 20, 2021
Merged

ENH: [Draft] Fix issue #35131 Identify zero-dimensional duck arrays as non-iterable #44626

merged 20 commits into from
Dec 20, 2021

Commits on Nov 26, 2021

  1. Add failing test

    @znicholls @burnpanck
    znicholls authored and burnpanck committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    3b8ebf0 View commit details
    Browse the repository at this point in the history

  2. Add __array__ method to mock numpy-like

    @znicholls @burnpanck
    znicholls authored and burnpanck committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    764a44e View commit details
    Browse the repository at this point in the history

  3. TST: GH35131 Add failing test of numpy-like array handling

    @znicholls @burnpanck
    znicholls authored and burnpanck committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    dabcf62 View commit details
    Browse the repository at this point in the history

  4. ENH: GH35131 Implement fix which allows numpy-like handling 

    Now pd.core.dtypes.inference.is_list_like correctly identifies numpy-like
scalars as not being iterable
    @znicholls @burnpanck
    znicholls authored and burnpanck committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    c0ce501 View commit details
    Browse the repository at this point in the history

  5. Simplify ndim check 

    Co-authored-by: keewis <[email protected]>
    @znicholls @keewis @burnpanck
    2 people authored and burnpanck committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    4ffe216 View commit details
    Browse the repository at this point in the history

  6. Revert change because it broke tests 

    I'm not completely sure why, but reverting here for simplicity
    @znicholls @burnpanck
    znicholls authored and burnpanck committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    d340a80 View commit details
    Browse the repository at this point in the history

  7. Use slightly clearer logic

    @znicholls @burnpanck
    znicholls authored and burnpanck committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    ad86e5d View commit details
    Browse the repository at this point in the history

  8. Update to use numpy iterable

    @znicholls @burnpanck
    znicholls authored and burnpanck committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    9a2eb94 View commit details
    Browse the repository at this point in the history

  9. Add failing is_scalar tests

    @znicholls @burnpanck
    znicholls authored and burnpanck committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    465dd37 View commit details
    Browse the repository at this point in the history

  10. Revert to relying on python's shortcircuit operators 

    Also avoid np.iterable
    @znicholls @burnpanck
    znicholls authored and burnpanck committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    b83109e View commit details
    Browse the repository at this point in the history

  11. Make a mess

    @znicholls @burnpanck
    znicholls authored and burnpanck committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    2e08233 View commit details
    Browse the repository at this point in the history

  12. Fix missing module

    @znicholls @burnpanck
    znicholls authored and burnpanck committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    8941c28 View commit details
    Browse the repository at this point in the history

  13. rebased to current master; reverted changes to assert_almost_equal

    @burnpanck
    burnpanck committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    2c58795 View commit details
    Browse the repository at this point in the history

  14. fix tests and clarify that a 0-dimensional duck-array is *NOT* a scal… 

    …ar (neither are 0-dimensional numpy arrays)
    @burnpanck
    burnpanck committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    e7bcee0 View commit details
    Browse the repository at this point in the history

  15. performance short-cuts for np.ndarray and list

    @burnpanck
    burnpanck committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    c4c348b View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2021

  1. changes requested during review by @jbrockmendel

    @burnpanck
    burnpanck committed Nov 27, 2021
    Configuration menu
    Copy the full SHA
    b285293 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2021

  1. Merge remote-tracking branch 'upstream/master' into bugfix/fix-35131-… 

    …zero-dim-duck-arrays
    @burnpanck
    burnpanck committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    41af909 View commit details
    Browse the repository at this point in the history

  2. change requested in review by jreback

    @burnpanck
    burnpanck committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    99af0bd View commit details
    Browse the repository at this point in the history

  3. made code comments a little bit more explicit

    @burnpanck
    burnpanck committed Dec 18, 2021
    Configuration menu
    Copy the full SHA
    8fff190 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2021

  1. Merge branch 'master' into bugfix/fix-35131-zero-dim-duck-arrays

    @jreback
    jreback authored Dec 19, 2021
    Configuration menu
    Copy the full SHA
    00ce2e0 View commit details
    Browse the repository at this point in the history