Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH36236 - Additional Test for df.join() #43700

Closed
wants to merge 6 commits into from
Closed

GH36236 - Additional Test for df.join() #43700

wants to merge 6 commits into from

Conversation

kasmith11
Copy link
Contributor

@kasmith11 kasmith11 commented Sep 22, 2021 •
edited
Loading

TST

@kasmith11
GH36236
76e03c8 
TST
@pep8speaks
Copy link

pep8speaks commented Sep 22, 2021 •
edited
Loading

Hello @kasmith11! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-09-27 14:22:52 UTC

@kasmith11 kasmith11 closed this Sep 22, 2021
@kasmith11 kasmith11 reopened this Sep 22, 2021
@kasmith11
Copy link
Contributor Author

@github-actions pre-commit

@debnathshoham
Copy link
Member

Hi @kasmith11. Thanks for the PR!
Is there a particular issue you're trying to address?

@debnathshoham debnathshoham added the Testing pandas testing functions or related to the test suite label Sep 22, 2021
@kasmith11
Copy link
Contributor Author

Hello @debnathshoham I wanted to contribute a test for the following issue.

@debnathshoham
Copy link
Member

Awesome! Could you please make the title to more informative.
And mark closes #36263 in the OP.

@debnathshoham debnathshoham added the Reshaping Concat, Merge/Join, Stack/Unstack, Explode label Sep 22, 2021
@kasmith11 kasmith11 changed the title GH36236 GH36236 - Additional Test for df.join() Sep 22, 2021
@kasmith11
Copy link
Contributor Author

@debnathshoham done!

attack68
attack68 requested changes Sep 23, 2021
View reviewed changes
pandas/tests/frame/methods/test_join.py


def test_join_duplicate_indicies():
df1 = pd.DataFrame(np.random.randn(5), index=[0, 1, 2, 3, 3], columns=["a"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add # GH xxxxx, with the relevant issue your solving with the test above this line.

@kasmith11
Copy link
Contributor Author

@github-actions pre-commit

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update or respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Oct 28, 2021
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale and the added test is still not passing the CI. If you'd like to continue, please merge master and we can reopen.

@mroeschke mroeschke closed this Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attack68 attack68 attack68 requested changes

Assignees
No one assigned
Labels
Reshaping Concat, Merge/Join, Stack/Unstack, Explode Stale Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pd.concat() crashes if dataframe contains duplicate indices but not df.join()
5 participants
@kasmith11 @pep8speaks @debnathshoham @mroeschke @attack68