Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: add sdist release workflow #41685

Merged
merged 21 commits into from
Jun 21, 2021
Merged

CI: add sdist release workflow #41685

merged 21 commits into from
Jun 21, 2021

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented May 26, 2021 •
edited
Loading

@fangchenli fangchenli added the CI Continuous Integration label May 26, 2021
@fangchenli fangchenli marked this pull request as draft June 3, 2021 19:20
@jorisvandenbossche jorisvandenbossche mentioned this pull request Jun 15, 2021
Closed
@jorisvandenbossche jorisvandenbossche changed the title CI: sdist test #39417 CI: add sdist release workflow Jun 15, 2021
@jorisvandenbossche
Copy link
Member

The version that Simon added (temporarily) in #38852 (2840c65) used a different environment to install the sdist. I think this is important to do here as well?

@jreback jreback added this to the 1.3 milestone Jun 16, 2021
@jreback
Copy link
Contributor

jreback commented Jun 17, 2021

@fangchenli if you have time to update would be good to get this working

@jorisvandenbossche
Copy link
Member

See also my comment above #41685 (comment) about Simon's version that uses a separate environment to install the sdist

@fangchenli
Copy link
Member Author

Build sdist without building pandas causes a

ModuleNotFoundError: No module named 'pandas._libs.interval'

while importing pandas

@simonjayhawkins
Copy link
Member

probably not using the installed pandas if /pandas directory still exists from where running the tests

@fangchenli fangchenli marked this pull request as ready for review June 17, 2021 17:55
simonjayhawkins
simonjayhawkins approved these changes Jun 18, 2021
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fangchenli generally lgtm. a couple of suggestions

.github/workflows/sdist.yml Outdated Show resolved Hide resolved
@jreback jreback merged commit 58bda71 into pandas-dev:master Jun 21, 2021
@jreback
Copy link
Contributor

jreback commented Jun 21, 2021

thanks @fangchenli

failures are unrelated (and i think on master)

@jreback
Copy link
Contributor

jreback commented Jun 21, 2021

@meeseeksdev backport 1.3.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jun 21, 2021
@fangchenli @meeseeksmachine
Backport PR pandas-dev#41685: CI: add sdist release workflow
5f71c95
@meeseeksmachine meeseeksmachine mentioned this pull request Jun 21, 2021
Merged
@lumberbot-app
Copy link

lumberbot-app bot commented Jun 21, 2021

Something went wrong ... Please have a look at my logs.

jreback pushed a commit that referenced this pull request Jun 21, 2021
@meeseeksmachine @fangchenli
Backport PR #41685: CI: add sdist release workflow (#42153)
e4b66c7 
Co-authored-by: Fangchen Li <[email protected]>
neinkeinkaffee pushed a commit to neinkeinkaffee/pandas that referenced this pull request Jun 21, 2021
@fangchenli @neinkeinkaffee
CI: add sdist release workflow (pandas-dev#41685)
d88be19
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@fangchenli @JulianWgs
CI: add sdist release workflow (pandas-dev#41685)
e68905b
@fangchenli fangchenli deleted the ci-sdist-test branch July 7, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

@jorisvandenbossche jorisvandenbossche jorisvandenbossche left review comments

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.

CI: add sdist test for PRs
4 participants
@fangchenli @jorisvandenbossche @jreback @simonjayhawkins