Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: enable arm64 build on drone.io #39730 #39742

Closed
wants to merge 30 commits into from

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Feb 11, 2021

@fangchenli fangchenli changed the title enable arm64 build on drone.io #39730 CI: enable arm64 build on drone.io #39730 Feb 11, 2021
@fangchenli fangchenli added ARM aarch64 architecture CI Continuous Integration labels Feb 11, 2021
@jreback
Copy link
Contributor

jreback commented Feb 15, 2021

a couple of thoughts here.

  • can you make multiple sections on drone, e.g. setup / build / test (mainly to separate out the building from the testing).
  • you can just start with very minimal deps, e.g. numpy & dateutil to make this faster.

@jreback
Copy link
Contributor

jreback commented Mar 8, 2021

great this looks like its running now; i would xfail the tests that are failing and open an issue for them.

@fangchenli
Copy link
Member Author

xref #38921 #38923

xpass #38798

@jreback jreback added this to the 1.3 milestone Mar 9, 2021
@jreback
Copy link
Contributor

jreback commented Mar 11, 2021

hmm looks like it is timing out, for sure skip the slow tests. maybe have to see what is slow on arm and re-add back the arm_slow (or similar) to skip more.

@fangchenli
Copy link
Member Author

The building phase took either 4 min or 14 min. Not sure why.

@fangchenli
Copy link
Member Author

drone_build_23
drone_build_24

@fangchenli
Copy link
Member Author

@jreback I asked Drone about the performance issue https://discourse.drone.io/t/unstable-performance-on-arm64/8833. This is the response:

Drone Cloud (cloud.drone.io) is our personal Drone instance that we make available to the public for testing and evaluation purposes; it has limited capacity. Once you evaluate the product, you should decide whether or not you want to install Drone on your own infrastructure (the same way you would install Jenkins). Drone is meant to be a Jenkins alternative (self-hosted) as opposed to a Travis alternative (saas).

@jreback
Copy link
Contributor

jreback commented Mar 13, 2021

so basically this is unusable :(

iirc numpy does build arm for CI but i don't recall exactly where

cc @seberg

@seberg
Copy link
Contributor

seberg commented Mar 13, 2021

We did not move away from TravisCI, instead apparently the right tree got shaken and (apparently enough) credits fell out: numpy/numpy#17824 (comment)

Is that is what you were asking? I suppose that should also work for pandas, but I am not sure about the correct "process" for it. Maybe pinging those involved directly, although it would be nice if there was a better solution after the initial quick policy-change...

@fangchenli
Copy link
Member Author

Let's find the right tree :)

@fangchenli fangchenli closed this Mar 14, 2021
@jreback
Copy link
Contributor

jreback commented Mar 14, 2021

i am going to hook us up with circleci which i think supports arm (or does so via a docker image)

@fangchenli fangchenli deleted the drone-ci branch March 18, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARM aarch64 architecture CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: enable drone.io
3 participants