Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Different tests were collected between gw0 and gw1 #37382

Conversation

simonjayhawkins
Copy link
Member

not sure if anyone else if having issue running tests locally. have created a clean pandas-dev env on a different machine so maybe a transient thing.

pytest-dev/pytest-xdist#432

INSTALLED VERSIONS
------------------
commit           : dce547ea2fe7f8c5c51c04d0a87704a2b4abf476
python           : 3.8.6.final.0
python-bits      : 64
OS               : Windows
OS-release       : 10
Version          : 10.0.18362
machine          : AMD64
processor        : Intel64 Family 6 Model 142 Stepping 12, GenuineIntel
byteorder        : little
LC_ALL           : None
LANG             : en_GB.UTF-8
LOCALE           : English_United Kingdom.1252

pandas           : 1.2.0.dev0+908.gdce547ea2f
numpy            : 1.19.2
pytz             : 2020.1
dateutil         : 2.8.1
pip              : 20.2.4
setuptools       : 49.6.0.post20201009
Cython           : 0.29.21
pytest           : 6.1.1
hypothesis       : 5.37.4
sphinx           : 3.2.1
blosc            : None
feather          : None
xlsxwriter       : 1.3.7
lxml.etree       : 4.6.1
html5lib         : 1.1
pymysql          : None
psycopg2         : None
jinja2           : 2.11.2
IPython          : 7.18.1
pandas_datareader: None
bs4              : 4.9.3
bottleneck       : 1.3.2
fsspec           : 0.8.4
fastparquet      : 0.4.1
gcsfs            : 0.7.1
matplotlib       : 3.3.2
numexpr          : 2.7.1
odfpy            : None
openpyxl         : 3.0.5
pandas_gbq       : None
pyarrow          : 2.0.0
pyxlsb           : None
s3fs             : 0.4.2
scipy            : 1.5.0
sqlalchemy       : 1.3.20
tables           : 3.6.1
tabulate         : 0.8.7
xarray           : 0.16.1
xlrd             : 1.2.0
xlwt             : 1.3.0
numba            : 0.51.2

@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Oct 24, 2020
@jbrockmendel
Copy link
Member

LGTM

@jreback jreback added this to the 1.2 milestone Oct 24, 2020
@jreback
Copy link
Contributor

jreback commented Oct 24, 2020

yep lgtm merge when greenish

Copy link
Member Author

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't merge yet.

maybe coincidence but the failing test, test_binary_arith_ops (failing elsewhere, see #37328) is parametrerised with test _good_arith_ops which is changed here

@simonjayhawkins simonjayhawkins marked this pull request as draft October 24, 2020 20:47
@topper-123
Copy link
Contributor

I'm on windows and these failures seem to be windows specific. So I've done some bisecting, and the first failing PR for me is #35964 (commit ab5b38d). Haven't checked what precisely it is there, but could be the parametrization over transformation_kernels (a set).

These are also fairly old commits, so I'm wondering why they're failing now. Maybe an incompatable update has been done in xdist or pytest?

@topper-123
Copy link
Contributor

@simonjayhawkins , can we merge this? With these changes everythings runs on my machine and evidently also on the CI.

The changes to _good_arith_ops look reasonable to me, so IMO should be kept.

@simonjayhawkins simonjayhawkins marked this pull request as ready for review October 25, 2020 21:56
@simonjayhawkins simonjayhawkins merged commit c10c101 into pandas-dev:master Oct 25, 2020
@simonjayhawkins simonjayhawkins deleted the Different-tests-were-collected-between-gw0-and-gw1 branch October 26, 2020 09:40
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants