Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: Remove trailing commas #36295

Closed
wants to merge 2 commits into from
Closed

CLN: Remove trailing commas #36295

wants to merge 2 commits into from

Conversation

cjlynch278
Copy link
Contributor

@cjlynch278 cjlynch278 commented Sep 11, 2020

Working on: CLN remove unnecessary trailing commas to get ready for new version of black #35925.
Updated the following files:
pandas/tests/series/methods/test_interpolate.py
pandas/tests/series/methods/test_unstack.py
pandas/tests/series/test_cumulative.py
pandas/tests/test_algos.py

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Lynch added 2 commits September 11, 2020 13:40
…erpolate.py

pandas/tests/series/methods/test_unstack.py
pandas/tests/series/test_cumulative.py
pandas/tests/test_algos.py
@pep8speaks
Copy link

Hello @cjlynch278! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 105:89: E501 line too long (154 > 88 characters)
Line 132:89: E501 line too long (154 > 88 characters)
Line 140:89: E501 line too long (139 > 88 characters)
Line 151:89: E501 line too long (154 > 88 characters)
Line 163:89: E501 line too long (154 > 88 characters)
Line 173:89: E501 line too long (92 > 88 characters)
Line 213:38: E231 missing whitespace after ','
Line 213:89: E501 line too long (122 > 88 characters)
Line 403:89: E501 line too long (269 > 88 characters)
Line 502:89: E501 line too long (97 > 88 characters)
Line 504:89: E501 line too long (104 > 88 characters)
Line 615:35: E231 missing whitespace after ','
Line 615:89: E501 line too long (141 > 88 characters)
Line 661:89: E501 line too long (113 > 88 characters)

Line 10:89: E501 line too long (108 > 88 characters)
Line 15:89: E501 line too long (121 > 88 characters)
Line 22:89: E501 line too long (141 > 88 characters)
Line 24:89: E501 line too long (116 > 88 characters)
Line 38:89: E501 line too long (123 > 88 characters)
Line 40:89: E501 line too long (104 > 88 characters)
Line 54:89: E501 line too long (187 > 88 characters)
Line 73:89: E501 line too long (106 > 88 characters)
Line 74:5: E123 closing bracket does not match indentation of opening bracket's line
Line 102:89: E501 line too long (159 > 88 characters)

Line 41:89: E501 line too long (118 > 88 characters)
Line 51:89: E501 line too long (118 > 88 characters)
Line 145:89: E501 line too long (128 > 88 characters)

Line 15:89: E501 line too long (122 > 88 characters)
Line 19:89: E501 line too long (106 > 88 characters)
Line 264:89: E501 line too long (152 > 88 characters)
Line 265:10: E202 whitespace before ')'
Line 282:9: E121 continuation line under-indented for hanging indent
Line 282:10: E202 whitespace before ')'
Line 332:10: E202 whitespace before ')'
Line 354:10: E202 whitespace before ')'
Line 428:89: E501 line too long (140 > 88 characters)
Line 428:139: E202 whitespace before ')'
Line 430:89: E501 line too long (134 > 88 characters)
Line 430:100: E231 missing whitespace after ','
Line 430:132: E202 whitespace before ']'
Line 532:89: E501 line too long (121 > 88 characters)
Line 533:89: E501 line too long (115 > 88 characters)
Line 536:63: E231 missing whitespace after ','
Line 536:89: E501 line too long (112 > 88 characters)
Line 537:89: E501 line too long (104 > 88 characters)
Line 542:62: E231 missing whitespace after ','
Line 542:89: E501 line too long (102 > 88 characters)
Line 551:89: E501 line too long (99 > 88 characters)
Line 574:89: E501 line too long (112 > 88 characters)
Line 574:111: E202 whitespace before ']'
Line 590:45: E231 missing whitespace after ','
Line 590:89: E501 line too long (147 > 88 characters)
Line 590:145: E231 missing whitespace after ','
Line 949:89: E501 line too long (144 > 88 characters)
Line 953:89: E501 line too long (107 > 88 characters)
Line 979:89: E501 line too long (105 > 88 characters)
Line 986:89: E501 line too long (93 > 88 characters)
Line 989:27: E201 whitespace after '('
Line 989:62: E201 whitespace after '('
Line 989:89: E501 line too long (121 > 88 characters)
Line 993:89: E501 line too long (130 > 88 characters)
Line 1000:89: E501 line too long (119 > 88 characters)
Line 1006:32: E201 whitespace after '('
Line 1006:86: E231 missing whitespace after ','
Line 1006:89: E501 line too long (122 > 88 characters)
Line 1007:89: E501 line too long (123 > 88 characters)
Line 1009:89: E501 line too long (128 > 88 characters)
Line 1010:89: E501 line too long (140 > 88 characters)
Line 1011:89: E501 line too long (117 > 88 characters)
Line 1012:89: E501 line too long (118 > 88 characters)
Line 1014:89: E501 line too long (123 > 88 characters)
Line 1099:89: E501 line too long (103 > 88 characters)
Line 1148:89: E501 line too long (137 > 88 characters)
Line 1148:104: E231 missing whitespace after ','
Line 1148:117: E231 missing whitespace after ','
Line 1149:89: E501 line too long (107 > 88 characters)
Line 1151:89: E501 line too long (240 > 88 characters)
Line 1172:89: E501 line too long (95 > 88 characters)
Line 1183:89: E501 line too long (96 > 88 characters)
Line 1204:89: E501 line too long (113 > 88 characters)
Line 1205:89: E231 missing whitespace after ','
Line 1205:89: E501 line too long (163 > 88 characters)
Line 1396:66: E231 missing whitespace after ','
Line 1396:89: E501 line too long (287 > 88 characters)
Line 1396:232: E231 missing whitespace after ','
Line 1434:89: E501 line too long (168 > 88 characters)
Line 1467:89: E501 line too long (165 > 88 characters)
Line 1499:89: E501 line too long (124 > 88 characters)
Line 1569:38: E231 missing whitespace after ','
Line 1569:89: E501 line too long (129 > 88 characters)
Line 1775:19: E231 missing whitespace after ','

@dsaxton dsaxton added the Clean label Sep 11, 2020
@dsaxton
Copy link
Member

dsaxton commented Sep 11, 2020

@cjlynch278 It looks like there may have been accidental changes to logic (there are some test failures). You'll also want to run black to fix linting.

@dsaxton dsaxton changed the title Cjlynch branch CLN: Remove trailing commas Sep 11, 2020
@MarcoGorelli
Copy link
Member

Hi @cjlynch278

Workflow here should be:

  • update black to new version
  • run black on files
  • for the lines that have changed, try removing trailing commas
  • run black on files again
  • downgrade black to current version, check nothing changes

@MarcoGorelli
Copy link
Member

Hi @cjlynch278 - is this still active?

@cjlynch278 cjlynch278 closed this Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants