TST verify groupby doesn't alter unit64s to floats #30859 #36164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Sep 6, 2020
pandas/tests/groupby/test_groupby.py
Outdated
| test_value = 16148277970000000000 | ||
| df = pd.DataFrame({"first": [1], "second": [1], "value": [test_value]}) | ||
| df_grouped = df.groupby(["first", "second"])["value"].max() | ||
| assert df_grouped.values == test_value |
There was a problem hiding this comment.
can you call df_grouped -> result
and then construct expected and use
tm.assert_frame_equal(result, expected)
also move the test somewhere around this test test_groupby_dtype_inference_empty
jreback
added
Dtype Conversions
jreback
approved these changes
Sep 7, 2020
|
thanks @TAJD |
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Sep 8, 2020
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffLogic of the test is to check that the value hasn't changes and that the dtype remains uint64.