Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compressed multiindex for output of groupby.rolling #36152

Merged
merged 4 commits into from
Sep 7, 2020

Conversation

phofl
Copy link
Member

@phofl phofl commented Sep 5, 2020

The number of leves for MultiIndex in input was compressed to one, because the tuples representing the Index rows were not unpacked. Also name was used instead of names -> resulted in missing name for every MultiIndex.

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment otherwise LGTM

pandas/tests/groupby/test_groupby.py Outdated Show resolved Hide resolved
@mroeschke mroeschke added Bug Groupby Window rolling, ewma, expanding labels Sep 6, 2020
@mroeschke mroeschke added this to the 1.2 milestone Sep 6, 2020
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phofl - just a minor request.

pandas/tests/groupby/test_groupby.py Outdated Show resolved Hide resolved
pandas/core/window/rolling.py Outdated Show resolved Hide resolved
pandas/core/window/rolling.py Outdated Show resolved Hide resolved
doc/source/whatsnew/v1.2.0.rst Outdated Show resolved Hide resolved
@jreback jreback modified the milestones: 1.2, 1.1.2 Sep 6, 2020
@jreback jreback merged commit ce0476f into pandas-dev:master Sep 7, 2020
@jreback
Copy link
Contributor

jreback commented Sep 7, 2020

thanks @phofl very nice, keep em coming!

@simonjayhawkins
Copy link
Member

@meeseeksdev backport 1.1.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Sep 7, 2020
@phofl phofl deleted the 36018_nlevels_changed branch September 7, 2020 21:14
simonjayhawkins pushed a commit that referenced this pull request Sep 7, 2020
@simonjayhawkins simonjayhawkins mentioned this pull request Sep 8, 2020
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Sep 8, 2020
HyukjinKwon pushed a commit to databricks/koalas that referenced this pull request Sep 21, 2020
This should resolve #1685 

- [x] DataFrame.truncate
- [x] AtIndexer with MultiIndex
- [x] GroupBy.nunique
- [x] Index.monotonic
- [x] GroupByRolling.max (Resolved in pandas-dev/pandas#36152)
- [x] GroupByRolling.mean (ditto)
- [x] GroupByRolling.min (ditto)
- [x] GroupByRolling.std (ditto)
- [x] GroupByRolling.sum (ditto)
- [x] GroupByRolling.var (ditto)
- [x] Series.truncate
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
rising-star92 added a commit to rising-star92/databricks-koalas that referenced this pull request Jan 27, 2023
This should resolve #1685 

- [x] DataFrame.truncate
- [x] AtIndexer with MultiIndex
- [x] GroupBy.nunique
- [x] Index.monotonic
- [x] GroupByRolling.max (Resolved in pandas-dev/pandas#36152)
- [x] GroupByRolling.mean (ditto)
- [x] GroupByRolling.min (ditto)
- [x] GroupByRolling.std (ditto)
- [x] GroupByRolling.sum (ditto)
- [x] GroupByRolling.var (ditto)
- [x] Series.truncate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Groupby Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QST: is the new behavior of GroupByRolling for MultiIndex in v1.1.1 intended?
5 participants