BUG: copying series into empty dataframe does not preserve dataframe index name #36141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Sep 5, 2020
jreback
requested changes
Sep 5, 2020
|
|
||
| df["series"] = series | ||
|
|
||
| tm.assert_equal(df.index.name, "df_index") |
There was a problem hiding this comment.
can you construct the expected frame and use tm.assert_frame_equal
jreback
added
Index
|
also pls merge master |
jreback
approved these changes
Sep 8, 2020
|
@simonjayhawkins ok for 1.1.2 (if you haven't tagged), otherwise let's push to 1.1.3 |
ok for 1.1.2 |
|
Thanks @Dr-Irv |
|
@meeseeksdev backport 1.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Sep 8, 2020
…e does not preserve dataframe index name
|
Something went wrong ... Please have a look at my logs. |
1 similar comment
|
Something went wrong ... Please have a look at my logs. |
simonjayhawkins
pushed a commit
that referenced
this pull request
Sep 8, 2020
… preserve dataframe index name (#36221) Co-authored-by: Irv Lustig <[email protected]>
jbrockmendel
pushed a commit
to jbrockmendel/pandas
that referenced
this pull request
Sep 8, 2020
3 tasks
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
indexing/test_partial.py:TestPartialSetting:test_index_name_emptyblack pandasgit diff upstream/master -u -- "*.py" | flake8 --diff