-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: shows correct package name when import_optional_dependency is ca… #36134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a note in whatsnew 1.1.2 Other bug fix section is fine
lgtm ping on green |
@jreback All checks are green! |
I've restarted travis to see if failure persists. |
will be merging and backporting if green |
@simonjayhawkins The Travis CI build passed this time. Thanks for your help. |
Thanks @hs2361 |
@meeseeksdev backport 1.1.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
maybe due to release notes out of sync #35831 (comment) i'll resolve that and then see if the backport can be triggered a second time. |
@meeseeksdev backport 1.1.x |
1 similar comment
@meeseeksdev backport 1.1.x |
#36134) (#36199) Co-authored-by: Harsh Sharma <[email protected]>
…lled. fixes #35948
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff