Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #35852 on branch 1.1.x (API: replace dropna=False option with na_sentinel=None in factorize) #36071

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #35852: API: replace dropna=False option with na_sentinel=None in factorize

@lumberbot-app lumberbot-app bot added this to the 1.1.2 milestone Sep 2, 2020
@jreback
Copy link
Contributor

jreback commented Sep 2, 2020

@charlesdong1991 and can merge this when green as well

@simonjayhawkins
Copy link
Member

@charlesdong1991 and can merge this when green as well

and when merging on the backport branch ensure that Co-authored-by: Kaiqi Dong [email protected] or whoever the author is is included otherwise they won't appear in the contributors list

@charlesdong1991
Copy link
Member

may I kindly ask how to check if the author is included in this case? 😅 @simonjayhawkins

@simonjayhawkins
Copy link
Member

when you click on confirm squash and merge you'll see

image

so the the co-author is included automatically. just need to ensure that if cleaning the description that you don't remove the co-author (i.e. the original author)

@charlesdong1991
Copy link
Member

yep, get it! thanks very much! @simonjayhawkins

@charlesdong1991 charlesdong1991 merged commit 9bc223e into pandas-dev:1.1.x Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants