CLN remove unnecessary trailing commas in pandas/io

[sarthakvk]

@MarcoGorelli can you review this PR this is related to issue #35925, if this looks good to you I can open another PR

• pandas/io/sas/sas_xport.py

• pandas/io/stata.py

• passes black pandas

[pep8speaks]

Hello @sarthakchaudhary13! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-03 11:12:51 UTC

[dsaxton]

Thanks @sarthakchaudhary13, can you run black on /pandas/io to get linting green?

[sarthakvk]

Thanks for reviewing this PR @dsaxton, this is the output after re-running black on pandas/io.

$ black pandas/io
All done! ✨ 🍰 ✨ 
47 files left unchanged. 

[MarcoGorelli]

Thanks for reviewing this PR @dsaxton, this is the output after re-running black on pandas/io.

$ black pandas/io
All done! ✨ 🍰 ✨ 
47 files left unchanged. 

Can you check this with black version 19.10b0 as well, as that's the version that's run during CI? Ideally, you would:

• upgrade black
• run black on some files
• check what's changed, and try removing the trailing commas
• run black again
• downgrade black to version 19.10b0 and check everything is still fine

[sarthakvk]

Can you check this with black version 19.10b0 as well, as that's the version that's run during CI? Ideally, you would:

* upgrade `black`

* run `black` on some files

* check what's changed, and try removing the trailing commas

* run `black` again

* downgrade `black` to version 19.10b0 and check everything is still fine

@MarcoGorelli Thanks for the tip, both black versions checks are passing
I did a git revert for my previous commit but somehow other files also got changed, can you help me to fix this 😞

[MarcoGorelli]

@sarthakchaudhary13 I think I would do something like

git fetch upstream master
git rebase -i upstream/master  # choose which commits you want to keep
git push origin <your branch name> -f

[sarthakvk]

@sarthakchaudhary13 I think I would do something like

git fetch upstream master
git rebase -i upstream/master  # choose which commits you want to keep
git push origin <your branch name> -f

@MarcoGorelli Thanks, if this looks good to you I can open another PR with fixing more files 😄

[MarcoGorelli]

Nice one @sarthakchaudhary13 ! And sure, any help here would be appreciated

[MarcoGorelli]

@sarthakchaudhary13 looks like there's a merge conflict, could you fetch and merge upstream/master and then push again please?

[sarthakvk]

@sarthakchaudhary13 looks like there's a merge conflict, could you fetch and merge upstream/master and then push again please?

Yeah sure.

[WillAyd]

Thanks @sarthakchaudhary13