Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add mode.mangle_dupe_cols option GH3468 #3511

Merged
2 commits merged into from May 5, 2013
Merged

ENH: add mode.mangle_dupe_cols option GH3468 #3511

2 commits merged into from May 5, 2013

Conversation

ghost
Copy link

@ghost ghost commented May 2, 2013

#3468

as discussed, an added option to disable th mangling behavior
of dupe columns taken by pd.read_csv going back to olden days.

Not sure what the default should be, currently the default is compatible
with existing scripts.

Tested with both c and python parser engines.

@jreback
Copy link
Contributor

jreback commented May 2, 2013

what about doing this as an argument to read_csv, say duplicate_column_names=False, default should prob be False but that breaks API ......

@ghost
Copy link
Author

ghost commented May 2, 2013

yeah, I'll go for that. still not sure about the default though. Still compatible right now.
if it breaks back compat, I'll push this to 0.12.

@jreback
Copy link
Contributor

jreback commented May 2, 2013

actually I think we should put in the option now
but leave the default = True so doesn't break API compat
(then maybe break in 0.12)?

@ghost
Copy link
Author

ghost commented May 2, 2013

works for me, added note to RELEASE.rst.

ghost pushed a commit that referenced this pull request May 5, 2013
ENH: add mode.mangle_dupe_cols option GH3468
@ghost ghost merged commit 4ecb04e into pandas-dev:master May 5, 2013
@ghost ghost deleted the PR_mangle_dupe_cols_option branch May 5, 2013 09:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant