API: Store name outside attrs #30798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns with xarray and h5py: pandas-dev#29062 (comment)
jbrockmendel
reviewed
Jan 7, 2020
pandas/core/series.py
Outdated
| @@ -159,7 +159,8 @@ class Series(base.IndexOpsMixin, generic.NDFrame): | |||
|
|
|||
| _typ = "series" | |||
|
|
|||
| _metadata: List[str] = [] | |||
| _name: Hashable | |||
|
sure x- @jbrockmendel comment. |
|
@TomAugspurger maybe also add a note somewhere that |
|
|
||
| .. warning:: | ||
|
|
||
| attrs is experimental and may change without warning. |
There was a problem hiding this comment.
Thanks! Can you also add this in the reference docs (where you added it in https://github.com/pandas-dev/pandas/pull/29062/files)
jorisvandenbossche
approved these changes
Jan 8, 2020
|
When will this feature be not experimental? Is allows for persistence of data when pickling on accessors. I would encourage to remove the experimental tag. |
|
You can remove the experimental label if you want. The basics aren't go to change. However, there are two future changes that will affect things in attrs
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns with xarray and h5py:
#29062 (comment)