DEPR: remove Index fastpath kwarg #29725
Conversation
| fastpath=None, | ||
| tupleize_cols=True, | ||
| **kwargs, | ||
| cls, data=None, dtype=None, copy=False, name=None, tupleize_cols=True, **kwargs, |
There was a problem hiding this comment.
Not sure how we historically handle but unfortunate this accepts kwargs - I suppose if someone keeps supplying fastpath nothing will change. Not sure if we should explicitly raise now in that case
There was a problem hiding this comment.
I changed test_deprecated_fastpath so instead of checking for a FutureWarning, it checks for a TypeError
|
@WillAyd are the mypy complaints actually caused by something here or just a coincidence? |
|
Doesn't make sense on first glance; just restarted let's see |
| @@ -269,6 +269,8 @@ or ``matplotlib.Axes.plot``. See :ref:`plotting.formatters` for more. | |||
|
|
|||
| **Other removals** | |||
|
|
|||
| - Removed the previously deprecated :meth:`Index.summary` (:issue:`18217`) | |||
There was a problem hiding this comment.
yes, this was what I had in mind for whatsnew placing.
|
@simonjayhawkins any ideas whats going on with mypy here? |
|
might be relevant to this issue @jbrockmendel |
we had this issue before, see #29205 (comment) did reach an agreement whether it is a bug or expected behaviour. the change to the function signatures has triggered this. |
suggestions on what to do here? It looks like @TomAugspurger was working on making a fixture for just [Index, Series] at one point |
Do you mean a TypeVar? I don't recall the details, but I think my preference was to add |
jbrockmendel
changed the title
There was a problem hiding this comment.
lgtm. I see your typing TODOs, any objections to simply merging and fixing later? @simonjayhawkins
sure |
|
Thanks @jbrockmendel |
| @@ -30,6 +31,19 @@ def adjust_negative_zero(zero, expected): | |||
| return expected | |||
|
|
|||
|
|
|||
| # TODO: remove this kludge once mypy stops giving false positives here | |||
There was a problem hiding this comment.
@simonjayhawkins any idea if this is something we can address?
No description provided.