Stop catching TypeError in groupby methods #29060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Oct 17, 2019
| try: | ||
| values = ensure_float64(values) | ||
| except TypeError: | ||
| if lib.infer_dtype(values, skipna=False) == "complex": |
There was a problem hiding this comment.
future PR should push this to pandas/core/dtypes/cast.py and just call here (maybe make ensure_float64_or_complex)
There was a problem hiding this comment.
yah. i think there was some discussion of a one-pass variant of lib.infer_dtype that would go well with that
we have a couple of tests that get here with an ndarray[object] containing complex objects |
jreback
approved these changes
Oct 17, 2019
|
thanks @jbrockmendel |
HawkinsBA
pushed a commit
to HawkinsBA/pandas
that referenced
this pull request
Oct 29, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @WillAyd @jreback
Note this doesn't touch cython_agg_blocks, I've run out of things to meddle with there.
Open to suggestions for the DecimalArray case.