-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up ufuncs post numpy bump #26606
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26606 +/- ##
==========================================
+ Coverage 91.85% 91.86% +<.01%
==========================================
Files 174 174
Lines 50707 50693 -14
==========================================
- Hits 46578 46568 -10
+ Misses 4129 4125 -4
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #26606 +/- ##
==========================================
+ Coverage 91.85% 91.86% +<.01%
==========================================
Files 174 174
Lines 50707 50693 -14
==========================================
- Hits 46578 46568 -10
+ Misses 4129 4125 -4
Continue to review full report at Codecov.
|
nice that this passes are there any other array_wrap* leftover? (in any class) |
There are a bunch left:
I only touched the sparse-stuff (according to the comment I followed for this PR), and hadn't checked which other classes already implement
|
these are fine as we have |
Found an old branch lying around I had forgotten about after the numpy bump, which had been requested by @TomAugspurger in this comment